-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added virtual network auto-creation if no virtual network found for azure_virtual_machine_with_public_ip role #77
Conversation
tests/integration/targets/test_azure_virtual_machine_with_public_ip/tasks/main.yml
Outdated
Show resolved
Hide resolved
88d4cbd
to
da0539a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please separate to 2 commits: 1 for the integration test and one for the role changes
If there are jira tickets for these commits, please mention the ids in the commit message
I suggest to have the commit messages with the following structure:
ticket_id: What changed
Why changed
Notice there is one empty line between the what
and why
(The why changed
part is not mandatory)
Is this breaking change? If users already use this role, would they need to make changes after update?
4eaa1d7
to
9ef316d
Compare
done. Now PR contains two commits with Jira tickets ID
No, If a virtual network exists, as it was required before, all changes will be skipped (I tested this scenario as well). |
9ef316d
to
9c50418
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some minor comments.
tests/integration/targets/test_azure_virtual_machine_with_public_ip/defaults/main.yml
Outdated
Show resolved
Hide resolved
…ual_machine_with_public_ip role
9c50418
to
7a28b38
Compare
For azure_virtual_machine_with_public_ip role: