Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACA-1602: Removing SKU tier, capacity and size parameters from role and test #89

Merged
merged 1 commit into from
Jul 22, 2024
Merged

ACA-1602: Removing SKU tier, capacity and size parameters from role and test #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/20240721-azure_manage_postgresql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- Removing tier, capacity, and size from SKU parameters from README file, both from Role Variables and Example Playbook
4 changes: 0 additions & 4 deletions roles/azure_manage_postgresql/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ Role Variables
* **azure_manage_postgresql_postgresql_name**: The name of the Server.
* **azure_manage_postgresql_postgresql_sku**: The SKU (pricing tier) of the server.
- **name**: The name of the SKU, typically, tier + family + cores, for example **B_Gen4_1**, **GP_Gen5_8**.
- **tier**: The tier of the particular SKU. Valid values are **Basic**, **Standard**.
- **capacity**: The scale up/out capacity, representing the server's compute units.
- **size**: The size code, to be interpreted by resource as appropriate.
* **azure_manage_postgresql_postgresql_storage_mb**: The maximum storage allowed for a server.
* **azure_manage_postgresql_postgresql_geo_redundant_backup**: Choose between locally redundant(default) or geo-redundant backup. This cannot be updated after first deployment. Default: **False**
* **azure_manage_postgresql_postgresql_backup_retention_days**: Backup retention period between 7 and 35 days. 7 days by default if not set
Expand Down Expand Up @@ -78,7 +75,6 @@ Example Playbook
azure_manage_postgresql_postgresql_storage_mb: 5120
azure_manage_postgresql_postgresql_sku:
name: B_Gen5_1
tier: Basic
azure_manage_postgresql_resource_group_tags:
tag0: "tag0"
tag1: "tag1"
Expand Down
1 change: 0 additions & 1 deletion tests/integration/targets/test_azure_manage_postgresql/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ azure_manage_postgresql_postgresql_name: "{{ resource_prefix }}-postgresql-serve
azure_manage_postgresql_postgresql_admin_username: "ansible"
azure_manage_postgresql_postgresql_sku:
name: "B_Gen5_1"
tier: "Basic"
azure_manage_postgresql_postgresql_storage_mb: 5120
azure_manage_postgresql_postgresql_backup_retention_days: 10
1 change: 0 additions & 1 deletion ...s/integration/targets/test_azure_manage_postgresql/tasks/create_and_delete_postgresql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
- _postgresql.servers[0].name == azure_manage_postgresql_postgresql_name
- _postgresql.servers[0].location == azure_manage_postgresql_region
- _postgresql.servers[0].sku.name == azure_manage_postgresql_postgresql_sku.name
- _postgresql.servers[0].sku.tier == azure_manage_postgresql_postgresql_sku.tier
- _postgresql.servers[0].storage_mb == azure_manage_postgresql_postgresql_storage_mb
- _postgresql.servers[0].admin_username == azure_manage_postgresql_postgresql_admin_username
- _postgresql.servers[0].version == azure_manage_postgresql_postgresql_version
Expand Down
Loading