Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the ansible-lint version to 24.7.0 and ansible version to min 2.15 #14

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Bump the ansible-lint version to 24.7.0 and ansible version to min 2.15 #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbe3665
add minimum version for ansible-lint to 24.7.0
mandar242 Jul 22, 2024
675f705
added changelog fragment
mandar242 Jul 22, 2024
dfddc2f
bump ansible-core min required version
mandar242 Jul 25, 2024
9a1bb77
update readme
mandar242 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/linters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Run ansible-lint
uses: ansible/ansible-lint@v6.22.0
- name: run-ansible-lint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change of step name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced it with new task from https://github.com/marketplace/actions/run-ansible-lint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

uses: ansible/ansible-lint@v24.7.0

tox-linters:
uses: ansible-network/github_actions/.github/workflows/tox-linters.yml@main
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ The collection includes a variety of Ansible roles and playbooks to help automat
<!--start requires_ansible-->
## Ansible version compatibility

This collection has been tested against following Ansible versions: **>=2.14.0**.
This collection has been tested against following Ansible versions: **>=2.15.0**.

## Python version compatibility

Expand Down
5 changes: 5 additions & 0 deletions changelogs/fragments/14-bump-ansible-lint-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
minor_changes:
- Bump version of ansible-lint to minimum 24.7.0 (https://github.com/redhat-cop/cloud.gcp_ops/pull/14).
breaking_changes:
- Bump minimum version requirement for ansible-core to 2.15 (https://github.com/redhat-cop/cloud.gcp_ops/pull/14).
2 changes: 1 addition & 1 deletion meta/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
requires_ansible: '>=2.14.0'
requires_ansible: '>=2.15.0'
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ install_command = pip install {opts} {packages}

[testenv:ansible-lint]
deps =
ansible-lint==6.22.0
ansible-lint >= 24.7.0
changedir = {toxinidir}
commands =
ansible-lint
Expand Down
Loading