improve info role outputs #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorency
requested review from
shellymiron,
elsapassaro,
prabinovRedhat,
anna-savina,
bardielle and
machacekondra
as code owners
bardielle
approved these changes
Oct 6, 2024
|
@machacekondra please review it as well |
machacekondra
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes two suggestions from the testathon feedback.
inforole's output filenamesFor the first suggestion, the recommendation was to make the output filenames simpler and let the user create randomized names if they want. I also made writing output files optional since many users did not find them useful. The default is to still output files, since that is what we did previously.
I also noticed that the community.general collection was referenced by a lot of tests when it wasnt actually being used so I removed that reference.
For the second suggestion, I added a variable that is optionally set with the gathered info. Its documented in the README and uses a variable name that is unlikely to cause any conflicts. The user can opt out of this variable. They may want to do so to save memory, since the data gathered can be quite large in size.