add first integration CI test to run on eco vcenter #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellymiron
force-pushed
the
add_integration_ci_vcenter_info
branch
2 times, most recently
from
4fceef1
to
3195f0f
Compare
bardielle
reviewed
May 27, 2024
elsapassaro
reviewed
May 27, 2024
shellymiron
force-pushed
the
add_integration_ci_vcenter_info
branch
21 times, most recently
from
0d8967d
to
fdeb335
Compare
mikemorency
reviewed
May 28, 2024
bardielle
reviewed
May 28, 2024
shellymiron
force-pushed
the
add_integration_ci_vcenter_info
branch
2 times, most recently
from
d12a5d0
to
72c76d0
Compare
shellymiron
force-pushed
the
add_integration_ci_vcenter_info
branch
12 times, most recently
from
30019be
to
e478335
Compare
bardielle
reviewed
Jun 2, 2024
bardielle
reviewed
Jun 2, 2024
shellymiron
force-pushed
the
add_integration_ci_vcenter_info
branch
3 times, most recently
from
2555f8a
to
0fef633
Compare
bardielle
reviewed
Jun 2, 2024
bardielle
reviewed
Jun 2, 2024
bardielle
reviewed
Jun 2, 2024
shellymiron
force-pushed
the
add_integration_ci_vcenter_info
branch
from
0fef633
to
d8461e5
Compare
elsapassaro
approved these changes
Jun 3, 2024
|
/lgtm |
|
Had one small comment, beside it LGTM |
shellymiron
force-pushed
the
add_integration_ci_vcenter_info
branch
from
d8461e5
to
ec3dffa
Compare
|
@bardielle added details to the comment |
|
@elsapassaro @bardielle @mikemorency can I merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step to establish a CI in upstream (similar CI will be opened for vmware.vmware repo), that runs the integration tests on the real vcenter environment we have behind redhat vpn.
Few notes:
This PR includes the action itself, some enhancements and modifications to the current info test we have in the
integration folder. the intention is to do the same for the rest of the integration tests (existing and new ones) one by
one, so that they could run both on vcsim (or as rest calls) and on the real vcenter env.
In order for the PR to work, and so does others, I'll need to request to add the following secrets github env to the current repo: VCENTER_HOSTNAME, VCENTER_PASSWORD, VCENTER_USERNAME. I'll need dev for that, so will ask one of you for a help with that @bardielle @mikemorency @machacekondra
The info test is skipped for current CI integration (vcsim) as I can tell from looking in other PRs jobs. in my PR it is not skipped, hence, it is failing and I'll need dev assistance to see why and how to fix that. other tests seems to work.
Please help to review and be as much critical as you can :D
(note - the jobs will not run properly before we will do the adjustments as described above, you can take a look of how it supposed to be after the changes here)
also, check the epic here for better understand the effort for this CI.