add role to manage folders #47
Conversation
mikemorency
force-pushed
the
mm-feature/ACA-1588-create-vm-folder
branch
from
4759946
to
665c9f8
Compare
mikemorency
force-pushed
the
mm-feature/ACA-1588-create-vm-folder
branch
from
49efb07
to
b81cbe6
Compare
mikemorency
requested review from
shellymiron,
elsapassaro,
bardielle and
machacekondra
as code owners
Co-authored-by: Shelly Miron <[email protected]>
|
@mikemorency I have the tests ready for this PR, so once it merged, i'll open mine |
| - name: Fail If Folder Path Is Absolute | ||
| ansible.builtin.fail: | ||
| msg: Folder name should not be absolute. It should be relative to /<datacenter>/<type> | ||
| when: manage_folder_folder_name[0] == '/' |
There was a problem hiding this comment.
Maybe I'm wrong
I think you mean to fail if manage_folder_folder_name[0] != '/'
There was a problem hiding this comment.
No, the check is correct. Its making sure the user does not input a path/folder that starts with a slash
| - uat/foo/web | ||
| - development/foo/web | ||
|
|
||
| - name: Create Folders Without Managing Full Tree |
There was a problem hiding this comment.
Does it mean to create only foo?
There was a problem hiding this comment.
it would create manage_folder_folder_name, so either backend or db in the already existing manage_folder_parent_folder
This is like running mkdir production/foo/backend for example
| msg: Folder name should not be absolute. It should be relative to /<datacenter>/<type> | ||
| when: manage_folder_folder_name[0] == '/' | ||
|
|
||
| - name: Manage Full Folder Path |
There was a problem hiding this comment.
This would be way nicer to have part of the module community.vmware.vcenter_folder IMHO.
There was a problem hiding this comment.
Agree - maybe we can open a ticket for that?
Allows a user to create or delete a folder tree in vmware, or create just the final folder in a tree. For example
Create any missing folders along the path
/DC01/vms/my/production/webOr just create the folder
webin the already existing path/DC01/vms/my/production