Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping of validation of previous analysis results. #162

Merged

Conversation

jeffmcutter
Copy link
Collaborator

This allows the approach of:

  1. Run analysis and check if there are any unknown inhibitors not already known and handled by remediation. If there are unknown inhibitors to the remediation automation, then those need to be addressed, if not...
  2. Go straight to upgrade which includes snapshot, remediation, upgrade, etc. without running analysis again.

This is safe because the leapp upgrade will stop anyways if there are still inhibitors remaining after remediation.

This change does not change the existing default behavior, only allows an override of it.

This allows the approach of:
1. Run analysis and check if there are any unknown inhibitors not already known and handled by remediation.
2. Go straight to upgrade which includes snapshot, remediation, upgrade, etc. without running analysis again.

This is fine because the leapp upgrade will stop anyways if there are still inhibitors remaining after remediation.
Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like you pointed out I think this could reduce upgrade time by a decent amount if people are interested in that

@swapdisk swapdisk merged commit 9b53824 into redhat-cop:main Mar 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants