Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] JBDS-4470 Load configuration from remote repository #811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dgolovin
Copy link
Contributor

@dgolovin dgolovin commented Aug 2, 2017

Unsolved issues for this PR are:

  • CWE-502 - there should be input file verification, that it is coming from trusted source
  • Installer should support not only configuration download (see above) but also update for installer itself to be able to deliver latest changes in installation process (if any) for new/updated components

@dgolovin dgolovin changed the title JBDS-4470 [WIP]Load configuration from remote repository [WIP] JBDS-4470 Load configuration from remote repository Dec 8, 2017
@codecov-io
Copy link

codecov-io commented Feb 17, 2018

Codecov Report

Merging #811 into master will decrease coverage by 6.14%.
The diff coverage is 54.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
- Coverage   97.73%   91.58%   -6.15%     
==========================================
  Files          35       35              
  Lines        3085     3340     +255     
  Branches      258      468     +210     
==========================================
+ Hits         3015     3059      +44     
- Misses         70      275     +205     
- Partials        0        6       +6
Impacted Files Coverage Δ
browser/pages/confirm/controller.js 52.84% <48%> (-46.05%) ⬇️
browser/services/data.js 96.24% <91.66%> (-1.58%) ⬇️
browser/services/componentLoader.js 77.86% <0%> (-22.14%) ⬇️
browser/model/jbosseap.js 85.71% <0%> (-14.29%) ⬇️
browser/model/kompose.js 86.27% <0%> (-13.73%) ⬇️
browser/model/jbossfusekaraf.js 87.32% <0%> (-12.68%) ⬇️
browser/model/hyperv.js 91.66% <0%> (-8.34%) ⬇️
browser/model/cdk.js 93.79% <0%> (-6.21%) ⬇️
browser/model/jbossfuse.js 94.4% <0%> (-5.6%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c932d4...bad0280. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants