Skip to content

Commit

Permalink
Removing .NET 7 from tests, removing outdated tests and increasing
Browse files Browse the repository at this point in the history
timeout-minutes

Cleaning up tests by removing references to .NET 7 and removing tests
made for older, now unsupported versions of .NET. Also increasing
the timeout limit for install .NET and test dependencies due to frequent
timeouts on Fedora.
  • Loading branch information
nicrowe00 committed Jun 5, 2024
1 parent 8cde53a commit 279339e
Show file tree
Hide file tree
Showing 10 changed files with 11 additions and 227 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- uses: actions/checkout@v4

- name: Install .NET ${{ matrix.dotnet_version }}
timeout-minutes: 5
timeout-minutes: 10
run: |
set -euo pipefail
cat /etc/os-release
Expand All @@ -69,7 +69,7 @@ jobs:
fi
- name: Install Test dependencies
timeout-minutes: 2
timeout-minutes: 5
run: |
if grep fedora /etc/os-release ; then
dnf install -y python3 wget $(grep '^Dependencies(dnf): ' README.md | cut -d: -f2-) --skip-broken
Expand Down
11 changes: 0 additions & 11 deletions aspnetpatch-21/test.json

This file was deleted.

141 changes: 0 additions & 141 deletions aspnetpatch-21/test.sh

This file was deleted.

20 changes: 9 additions & 11 deletions debugging-via-dotnet-dump/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -319,17 +319,15 @@ grep 'Attributes: *PEFile' dump.out
grep 'MetaData start address: *0' dump.out


# FIXME: dumpmt seems to work on 7.0.1 but not 7.0.0?
# heading "dumpmt"
# dump-analyze 'name2ee *!System.String' > dump.out
# cat dump.out
# grep 'MethodTable:' dump.out | awk '{print $2}'
# string_method_table=$(grep 'MethodTable:' dump.out | awk '{print $2}')
# dump-analyze "dumpmt ${string_method_table}" > dump.out
# cat dump.out
# grep -E '^Name:[ \n\t]+System.String' dump.out
# grep -E "^File:[ \n\t]+${framework_dir}" dump.out

heading "dumpmt"
dump-analyze 'name2ee *!System.String' > dump.out
cat dump.out
grep 'MethodTable:' dump.out | awk '{print $2}'
string_method_table=$(grep 'MethodTable:' dump.out | awk '{print $2}')
dump-analyze "dumpmt ${string_method_table}" > dump.out
cat dump.out
grep -E '^Name:[ \n\t]+System.String' dump.out
grep -E "^File:[ \n\t]+${framework_dir}" dump.out

heading "dumpobj"
dump-analyze 'dumpstackobjects' > dump.out
Expand Down
11 changes: 0 additions & 11 deletions extract-bundle-dir/test.json

This file was deleted.

45 changes: 0 additions & 45 deletions extract-bundle-dir/test.sh

This file was deleted.

1 change: 0 additions & 1 deletion host-probes-rid-assets/test.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"cleanup": true,
"skipWhen": [
"os=alpine,version=6", // see https://github.com/redhat-developer/dotnet-regular-tests/pull/303#issuecomment-1755727884
"os=alpine,version=7",
],
"ignoredRIDs":[
]
Expand Down
1 change: 0 additions & 1 deletion managed-symbols-available/test.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"cleanup": true,
"skipWhen": [
"vmr-ci,version=6", // unpacking symbols is a hassle
"vmr-ci,version=7",
"non-packaged",
],
"ignoredRIDs":[
Expand Down
2 changes: 0 additions & 2 deletions restore-with-rid/test.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
"cleanup": true,
"skipWhen":[
"version=6,arch=s390x", // no runtime pack available
"version=7,arch=s390x",
"version=7,arch=ppc64le"
],
"ignoredRIDs":[
]
Expand Down
2 changes: 0 additions & 2 deletions sha1-validation/test.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
"type": "bash",
"cleanup": true,
"skipWhen": [
"os=rhel.9,version=7", // Test fails on RHEL9 with .NET 7: https://issues.redhat.com/browse/RHEL-25254
"os=centos.9,version=7", // Test fails on RHEL9 with .NET 7: https://issues.redhat.com/browse/RHEL-25254
],
"ignoredRIDs":[
]
Expand Down

0 comments on commit 279339e

Please sign in to comment.