Skip to content

Commit

Permalink
tools-in-path should use framework version, not sdk version. (#333)
Browse files Browse the repository at this point in the history
Since the latest release of dotnet 8, 8.0.101, tools-in-path has been failing
as even though there is a version of dotnet-ef for 8.0.1, it expects the dotnet framework installed to also be 8.0.1,
whereas the framework used in dotnet 8.0.1 is still 8.0.0 which causes a compatibility error and a test failure.
Instead of installing the version of dotnet-ef that matches the installed sdk version,
the test should download the version of dotnet-ef that matches the installed framework.
  • Loading branch information
nicrowe00 authored Jan 30, 2024
1 parent 99e5f34 commit ca4d94a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools-in-path/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ else
exit 1
fi

IFS='.-' read -ra VERSION_SPLIT <<< "$1"
dotnet tool update -g dotnet-ef --version "${VERSION_SPLIT[0]}.*-*"
framework_dir=$(../dotnet-directory --framework "$1")
dotnet tool update -g dotnet-ef --version "${framework_dir#*App/}.*-*"

dotnet ef --version

0 comments on commit ca4d94a

Please sign in to comment.