Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade argocd #811

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

svghadi
Copy link
Member

@svghadi svghadi commented Nov 22, 2024

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Mangaal and others added 3 commits November 22, 2024 13:01
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Copy link
Member Author

svghadi commented Nov 22, 2024

/retest

@svghadi
Copy link
Member Author

svghadi commented Nov 23, 2024

Test failure

    logger.go:42: 14:22:13 | 1-031_validate_toolchain/1-check | Kustomize version mismatch. Should be v5.4.2, is v5.4.3
    logger.go:42: 14:22:13 | 1-031_validate_toolchain/1-check | Helm version mismatch. Should be v3.15.2, is v3.15.4
    logger.go:42: 14:22:13 | 1-031_validate_toolchain/1-check | 

Signed-off-by: Siddhesh Ghadi <[email protected]>
Copy link
Contributor

@Mangaal Mangaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cbdaaad into redhat-developer:master Nov 25, 2024
25 checks passed
@svghadi svghadi deleted the upgrade-argocd branch November 25, 2024 06:52
@svghadi
Copy link
Member Author

svghadi commented Nov 25, 2024

/cherry-pick v1.15

@openshift-cherrypick-robot

@svghadi: new pull request created: #812

In response to this:

/cherry-pick v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@h3rmanj
Copy link

h3rmanj commented Nov 28, 2024

I'm waiting for a feature from argo v2.13, when do you expect to release this? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants