Skip to content

Upgrade Argo CD to v3 in GitOps operator #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Upgrade Argo CD to v3 in GitOps operator #918

wants to merge 11 commits into from
+5,869 −3,730

Conversation

nmirasch
Copy link

@nmirasch nmirasch commented Jul 9, 2025

What type of PR is this?
Upgrade Argo CD to v3 in GitOps operator.
Bring the latest argoproj-labs/argocd-operator@e1f05cb commit to gitops

@openshift-ci openshift-ci bot requested review from anandrkskd and varshab1210 July 9, 2025 16:34
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 9, 2025

Hi @nmirasch. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nmirasch nmirasch marked this pull request as draft July 9, 2025 16:34
@svghadi
Copy link
Member

svghadi commented Jul 10, 2025

/ok-to-test

@svghadi
Copy link
Member

svghadi commented Jul 10, 2025

/ok-to-test

1 similar comment
@svghadi
Copy link
Member

svghadi commented Jul 10, 2025

/ok-to-test

@nmirasch nmirasch marked this pull request as ready for review July 10, 2025 09:09
@openshift-ci openshift-ci bot requested a review from jgwest July 10, 2025 09:10
@aali309 aali309 mentioned this pull request Jul 10, 2025
Closed
4 tasks
@svghadi
Copy link
Member

svghadi commented Jul 11, 2025

/retest

1 similar comment
@svghadi
Copy link
Member

svghadi commented Jul 12, 2025

/retest

nmirasch and others added 9 commits July 14, 2025 09:13
@nmirasch
Upgrade Argo CD to v3 in GitOps operator
405eddc 
Signed-off-by: nmirasch <[email protected]>
@svghadi @nmirasch
Update CRDs
3bff8ff 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi @nmirasch
Update golang to 1.24 in CI
5378275 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi @nmirasch
Try brew image
d1d1c17 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi @nmirasch
Use mirrored image
d490078 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi @nmirasch
Add root user to dockerfiles
0a59a6e 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi @nmirasch
Use different image'
9defc32 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi @nmirasch
Revert "Add root user to dockerfiles"
b3764b2 
This reverts commit 34ac4b3.
@svghadi @nmirasch
Revert ci-operator changes
64e7fbc 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@nmirasch nmirasch force-pushed the update_argocd_version_to_v3.0.9 branch from 8328262 to 64e7fbc Compare July 14, 2025 07:15
svghadi added 2 commits July 15, 2025 19:22
@svghadi
Use SkipNameValidation to avoid controller name validation
df52c56 
With controller-runtime v0.19.0, unique controller name validation is
enforced. The operator fails to start due to this as we don't have unique
names. Use SkipNameValidation to ingnore the uniquness check and prevent panic.

Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Try rhel9 image
cef132f 
Signed-off-by: Siddhesh Ghadi <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 16, 2025

@nmirasch: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit cef132f link true /test unit
ci/prow/v4.17-kuttl-sequential cef132f link true /test v4.17-kuttl-sequential
ci/prow/v4.17-kuttl-parallel cef132f link true /test v4.17-kuttl-parallel
ci/prow/v4.14-kuttl-sequential cef132f link true /test v4.14-kuttl-sequential
ci/prow/v4.14-e2e cef132f link true /test v4.14-e2e
ci/prow/v4.17-e2e cef132f link true /test v4.17-e2e
ci/prow/v4.14-kuttl-parallel cef132f link true /test v4.14-kuttl-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@varshab1210 varshab1210 Awaiting requested review from varshab1210

@jgwest jgwest Awaiting requested review from jgwest

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmirasch @svghadi