Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encoding issue when executing tasks (#169) #197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lstocchi
Copy link
Contributor

It resolves #169 . Followed what's done in common. Could you please verify if it fixes your issue? If not, any suggestion? @jeffmaury Thanks

@lstocchi lstocchi requested a review from jeffmaury July 13, 2022 09:33
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not fix the problem on Windows. Might be an encoding issue on the CLI side

@lstocchi
Copy link
Contributor Author

lstocchi commented Jul 15, 2022

Did not fix the problem on Windows. Might be an encoding issue on the CLI side

:/ Can you please give it a try to see if the issue is there? If not, i'll try to investigate more on it. Thanks!!

@jeffmaury
Copy link
Member

Tried the same command that is launched by the plugin in both the Windows CMD and Git bash.exe and got no encoding issues. It seems to be related to ansi escape characters as the data that is corrupted is printed in blue by the CLI.

Also tried to run the same command in the IJ terminal (with launches git bash.exe) causes the ansi characters not to be correctly handled but not in the same way as the plugin

@lstocchi
Copy link
Contributor Author

@jeffmaury The ColoredProcessHandler should handle the ansi escape chars. This needs redhat-developer/intellij-common#154 to work

@lstocchi lstocchi requested a review from jeffmaury July 19, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoding issue in the build window on Windows
2 participants