fix: prevent from duplicate Qute parameter key

Signed-off-by: azerr <[email protected]>
redhat-developer · Aug 28, 2024 · 974a7fc · 974a7fc
1 parent 40c008c
commit 974a7fc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...redhat/devtools/intellij/qute/psi/internal/template/datamodel/CheckedTemplateSupport.java b/...redhat/devtools/intellij/qute/psi/internal/template/datamodel/CheckedTemplateSupport.java
@@ -291,7 +291,7 @@ public static void collectParameters(PsiMethod method, ITypeResolver typeResolve
                     if (templateOrFragment.getParameter(parameter.getKey()) == null) {
                         // Add parameter if it doesn't exist
                         // to avoid parameters duplication
-                        templateOrFragment.getParameters().add(parameter);
+                        templateOrFragment.addParameter(parameter);
                     }
                 }
             }

diff --git a/...redhat/devtools/intellij/qute/psi/internal/template/datamodel/TemplateRecordsSupport.java b/...redhat/devtools/intellij/qute/psi/internal/template/datamodel/TemplateRecordsSupport.java
@@ -98,7 +98,11 @@ private static DataModelTemplate<DataModelParameter> createTemplateDataModel(Psi
             DataModelParameter parameter = new DataModelParameter();
             parameter.setKey(field.getName());
             parameter.setSourceType(PsiTypeUtils.resolveSignature(field.getType(), field.isVarArgs()));
-            template.getParameters().add(parameter);
+            if (template.getParameter(parameter.getKey()) == null) {
+                // Add parameter if it doesn't exist
+                // to avoid parameters duplication
+                template.addParameter(parameter);
+            }
         }
 
         // Collect data parameters for the given template