Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute support for multi module project doesn't work #1164

Closed
angelozerr opened this issue Sep 14, 2023 · 6 comments · Fixed by #1177
Closed

Qute support for multi module project doesn't work #1164

angelozerr opened this issue Sep 14, 2023 · 6 comments · Fixed by #1177
Assignees
Labels
bug Something isn't working qute Qute support
Milestone

Comments

@angelozerr
Copy link
Contributor

@ia3andy please be aware that multi module project with Qute doesn't work (you need to open the Qute project and not a project which could have one / several Qute module)

To fix this issue, it requires some work on Qute LS redhat-developer/quarkus-ls#930

@angelozerr angelozerr added bug Something isn't working qute Qute support labels Sep 14, 2023
@angelozerr angelozerr self-assigned this Sep 14, 2023
@gbourant
Copy link

I was about to open a new issue but i will post it here since it seems relevant.

Assume you have the following template

{#include root.html }
{/include}

The root.html is defined in another project. When i press Ctrl and hover with the mouse the root.html , it says that it is unable to find it and asks if i want to create it.

@fbricon
Copy link
Contributor

fbricon commented Sep 16, 2023

@gbourant Can you attach sample projects?

@gbourant
Copy link

Sure @fbricon, soon it will be available.

@gbourant
Copy link

Alright, the project is available here:

Just run ./mvnw clean quarkus:dev in the root directory and it will build project-a and then run project-b.

So the project-a has the root.html and the project-b uses it at the index.html

root.html at project-a

hi from root template in project-a

<p>{#insert /}</p>

index.html at project-b

{#include root}
    message from project-b
{/include}

So you should something like this:

image

Now you should be able to reproduce it. ( if it doesn't work remember to load maven changes )

@angelozerr
Copy link
Contributor Author

Thanks @gbourant for sharing a sample with Qute multi module. Your usecase is not trivial but it highlights that we need to load dependencies between project too in redhat-developer/quarkus-ls#930

@angelozerr
Copy link
Contributor Author

I have supported multiple project on Qute language Server and JDT side in redhat-developer/quarkus-ls#940

See demo with vscode at redhat-developer/quarkus-ls#940 (comment)

Once this PR will be merged,I will create a PR for IJ to consume the Qute Language server which supports multi module and implement the new services on IJ side which need to collect a lits of Qute projects coming from multimodules

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this issue Sep 22, 2023
angelozerr added a commit to angelozerr/intellij-quarkus that referenced this issue Sep 22, 2023
@angelozerr angelozerr moved this to 👀 In review in IDE Cloudaptors Sep 22, 2023
fbricon pushed a commit that referenced this issue Sep 22, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qute Qute support
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants