Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: go-to-definition and inlay hint links for JDK classes #1067

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix: go-to-definition and inlay hint links for JDK classes #1067

merged 1 commit into from
Aug 1, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Aug 1, 2023

  • JDK classes use a different URI protocol (jrt:)
  • Don't use PsiNameIdentifierOwner.getNameIdentifier().getNavigationElement() as it opens the .class file instead of the source, if available

Fixes #1063

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@angelozerr
Copy link
Contributor

It works like a charm, great job @fbricon !

@angelozerr angelozerr merged commit a041918 into redhat-developer:main Aug 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open type from inlayhint doesn't work in Qute template
2 participants
@fbricon @angelozerr