Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't log IndexNotReadyException / ReadAction.CannotReadException error when attempt is not reached #1072

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

angelozerr
Copy link
Contributor

Don't log IndexNotReadyException / ReadAction.CannotReadException error when attempt is not reached

@angelozerr
Copy link
Contributor Author

This PR should fix this kind of error #1032

@angelozerr angelozerr self-assigned this Aug 2, 2023
@angelozerr angelozerr added this to the 1.24.0 milestone Aug 2, 2023
error when attempt is not reached

Signed-off-by: azerr <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@angelozerr angelozerr marked this pull request as ready for review August 3, 2023 09:42
@fbricon
Copy link
Contributor

fbricon commented Aug 3, 2023

  • set ideaVersion to IC-2023.2
  • opening quarkus-blast (after deleting .idea/)
  • open rest/GameController, keep pressing space
  • boom:
java.lang.Throwable: Too many non-blocking read actions submitted at once. Please use coalesceBy, BoundedTaskExecutor or another way of limiting the number of concurrently running threads.: 11 with similar stack traces are currently active
	at com.intellij.openapi.diagnostic.Logger.error(Logger.java:370)
	at com.intellij.openapi.application.impl.SubmissionTracker.preventTooManySubmissions(SubmissionTracker.java:45)
	at com.intellij.openapi.application.impl.NonBlockingReadActionImpl$Submission.<init>(NonBlockingReadActionImpl.java:272)
	at com.intellij.openapi.application.impl.NonBlockingReadActionImpl.submit(NonBlockingReadActionImpl.java:227)
	at com.redhat.devtools.intellij.lsp4ij.client.LSPCompletableFuture.nonBlockingReadActionPromise(LSPCompletableFuture.java:140)
	at com.redhat.devtools.intellij.lsp4ij.client.LSPCompletableFuture.<init>(LSPCompletableFuture.java:66)
	at com.redhat.devtools.intellij.lsp4ij.client.IndexAwareLanguageClient.runAsBackground(IndexAwareLanguageClient.java:42)
	at com.redhat.devtools.intellij.quarkus.lsp.QuarkusLanguageClient.getJavaDiagnostics(QuarkusLanguageClient.java:128)
	at jdk.internal.reflect.GeneratedMethodAccessor143.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.lambda$null$0(GenericEndpoint.java:65)
	at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.request(GenericEndpoint.java:120)
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleRequest(RemoteEndpoint.java:261)
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:190)
	at com.redhat.devtools.intellij.lsp4ij.LanguageServerWrapper.lambda$start$1(LanguageServerWrapper.java:326)
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804)
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

@fbricon fbricon merged commit ac72102 into redhat-developer:main Aug 3, 2023
10 of 11 checks passed
@angelozerr angelozerr added bug Something isn't working lsp4ij LSP client for IJ labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lsp4ij LSP client for IJ
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants