fix: don't leak deployment jar classes #1078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
commented
Aug 4, 2023
| boolean excludeTestCode) { | ||
| SearchScope searchScope = GlobalSearchScope.EMPTY_SCOPE; | ||
| SearchScope searchScope = GlobalSearchScope.moduleRuntimeScope(module, !excludeTestCode); |
There was a problem hiding this comment.
allows finding properties in RUNTIME scope
fbricon
commented
Aug 4, 2023
| @@ -126,7 +126,7 @@ private static void addLibrary(ModifiableRootModel model, List<VirtualFile>[] fi | |||
|
|
|||
| LibraryOrderEntry entry = model.findLibraryOrderEntry(library); | |||
| assert entry != null : library; | |||
| entry.setScope(DependencyScope.PROVIDED); | |||
| entry.setScope(DependencyScope.RUNTIME); | |||
There was a problem hiding this comment.
avoid deployment jars to leak classes in compile scope
fbricon
force-pushed
the
deploymentJars-improvements
branch
2 times, most recently
from
f88f734
to
d2c42ac
Compare
Signed-off-by: Fred Bricon <[email protected]>
fbricon
force-pushed
the
deploymentJars-improvements
branch
from
d2c42ac
to
c9c40db
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
superseded by #1221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fred Bricon [email protected]