-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Java file diagnostics is not refreshed when properties file is saved #1084
Merged
fbricon
merged 1 commit into
redhat-developer:main
from
angelozerr:properties-validation-refresh
Sep 10, 2023
Merged
fix: Java file diagnostics is not refreshed when properties file is saved #1084
fbricon
merged 1 commit into
redhat-developer:main
from
angelozerr:properties-validation-refresh
Sep 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos, SonarCloud Quality Gate passed! |
angelozerr
force-pushed
the
properties-validation-refresh
branch
from
September 8, 2023 13:25
82c76ab
to
c31f258
Compare
fbricon
reviewed
Sep 8, 2023
src/main/java/com/redhat/devtools/intellij/lsp4mp4ij/psi/core/project/AbstractConfigSource.java
Outdated
Show resolved
Hide resolved
angelozerr
force-pushed
the
properties-validation-refresh
branch
from
September 8, 2023 14:01
c31f258
to
ba460d7
Compare
fbricon
reviewed
Sep 8, 2023
...a/com/redhat/devtools/intellij/lsp4ij/operations/documentation/LSPDocumentationProvider.java
Outdated
Show resolved
Hide resolved
angelozerr
force-pushed
the
properties-validation-refresh
branch
from
September 8, 2023 15:01
ba460d7
to
01f8e19
Compare
Works great. Let's merge after CI passes |
angelozerr
force-pushed
the
properties-validation-refresh
branch
from
September 9, 2023 11:12
01f8e19
to
5a27bbe
Compare
fbricon
requested changes
Sep 9, 2023
...ain/java/com/redhat/devtools/intellij/lsp4mp4ij/psi/core/project/PsiMicroProfileProject.java
Show resolved
Hide resolved
...ain/java/com/redhat/devtools/intellij/lsp4mp4ij/psi/core/project/PsiMicroProfileProject.java
Show resolved
Hide resolved
...ain/java/com/redhat/devtools/intellij/lsp4mp4ij/psi/core/project/PsiMicroProfileProject.java
Show resolved
Hide resolved
angelozerr
force-pushed
the
properties-validation-refresh
branch
3 times, most recently
from
September 10, 2023 06:35
5b96cf5
to
e150754
Compare
fbricon
reviewed
Sep 10, 2023
...ain/java/com/redhat/devtools/intellij/lsp4mp4ij/psi/core/project/PsiMicroProfileProject.java
Outdated
Show resolved
Hide resolved
saved Fixes redhat-developer#860 Signed-off-by: azerr <[email protected]>
angelozerr
force-pushed
the
properties-validation-refresh
branch
from
September 10, 2023 09:19
e150754
to
0a286b9
Compare
CI are passed |
Kudos, SonarCloud Quality Gate passed! |
Thanks @angelozerr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Java file diagnostics is not refreshed when properties file is saved
Fixes #860