Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show LSP completion item documentation in popup #1115

Merged
merged 1 commit into from
Aug 23, 2023
Merged

feat: Show LSP completion item documentation in popup #1115

merged 1 commit into from
Aug 23, 2023

Conversation

angelozerr
Copy link
Contributor

feat: Show LSP completion item documentation in popup

Fixes #1046

@angelozerr angelozerr force-pushed the completion-doc branch 3 times, most recently from 554c11e to b900b15 Compare August 20, 2023 21:54
@angelozerr angelozerr marked this pull request as draft August 20, 2023 21:56
@angelozerr
Copy link
Contributor Author

This PR improve:

  • hover offset, now if yo hover value of property in application.properties you should see the value property instead of the property name.
  • show documentation when completion item is selected after checking the setting
    image
  • support for completionItem/resolve for documentation, the JSON of projectInfo should not contain documentation and the JSON should be not big now.

@angelozerr
Copy link
Contributor Author

the completion popup with documentation doesnt work for the moment.I need to investigate why.

@angelozerr
Copy link
Contributor Author

It should work now

image

but code is strange. I need toinvestigate more

@angelozerr angelozerr marked this pull request as ready for review August 21, 2023 15:16
@angelozerr
Copy link
Contributor Author

angelozerr commented Aug 21, 2023 •
edited
Loading

@fbricon the PR is ready to review it.

@angelozerr angelozerr force-pushed the completion-doc branch 2 times, most recently from f423f6e to d890a5e Compare August 22, 2023 06:34
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fbricon fbricon merged commit 2cde322 into redhat-developer:main Aug 23, 2023
12 checks passed
@fbricon
Copy link
Contributor

fbricon commented Aug 23, 2023

Thanks @angelozerr!

@angelozerr angelozerr mentioned this pull request Sep 28, 2023
Open
@ia3andy
Copy link

ia3andy commented Sep 29, 2023

@angelozerr could we make this a default behavior (maybe 2s)?

@angelozerr
Copy link
Contributor Author

@angelozerr could we make this a default behavior (maybe 2s)?

@ia3andy it is a standard setting from IJ which is used for any IJ completion like Java completion (to show javadoc). I don't want to override IJ settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show LSP completion item documentation in popup
3 participants
@angelozerr @fbricon @ia3andy