-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose MicroProfile server settings #1117
Conversation
dff5144
to
f363c3d
Compare
* Problem severity levels used by LSP4MP | ||
*/ | ||
//TODO move to lsp4ij? | ||
public enum ProblemSeverity { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using DiagnosticSeverity and null for none?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DiagnosticSeverity has other values like hint and info, which could be mapped to IJ's severities, but since we don't use them, eventually I kept ProblemSeverity, as it makes things simpler, less risks of confusion.
src/main/java/com/redhat/devtools/intellij/quarkus/lsp/QuarkusLanguageClient.java
Show resolved
Hide resolved
I also need to fix:
|
ad39913
to
cb71d46
Compare
Done, it provided no value. |
ac0a695
to
19f0682
Compare
173b94a
to
8ab24c2
Compare
I removed the unassigned inspection, as LSP4MP ignores the unassigned severity (you can't set it neither in vscode) I'm pondering whether to remove the duplicates inspection as well, since IJ sets the severity to error on its own, even though Properties Duplicates inspection is disabled (probably a bug in IJ) |
It is great! The dark mode should be improved but if you wish we can do that in an another PR. I think that we should use editor background (it means that it html should be dynamic, why not use Qute to load your HTML file and replace bagkground color with the IJ background color?) We can do that in a sperate PR if you wish. |
8ab24c2
to
164283f
Compare
Indeed it is better, the yellow div border should use perhaps a gray color, because in dark mode I find it is a little flashy. |
@fbricon do you think it is possible and easy to do to add a link the the M |
I actually thought about it then forgot to do it ;-) |
Signed-off-by: Fred Bricon <[email protected]>
164283f
to
9c95788
Compare
SonarCloud Quality Gate failed. 18 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Thanks so much @fbricon ! |
Part of #794
Signed-off-by: Fred Bricon [email protected]