feat: support for excluding properties from validation #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
force-pushed
the
excludes
branch
2 times, most recently
from
c05bb45
to
d0de100
Compare
angelozerr
reviewed
Sep 1, 2023
src/main/java/com/redhat/devtools/intellij/lsp4mp4ij/settings/MicroProfileInspectionsInfo.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Sep 1, 2023
...in/java/com/redhat/devtools/intellij/lsp4mp4ij/settings/UserDefinedMicroProfileSettings.java
Outdated
Show resolved
Hide resolved
|
It's a lie, no expression exclusions are handled on the server side: https://github.com/eclipse/lsp4mp/blob/bd75514388241a81b3bcdf7dd862f22fbe46df31/microprofile.ls/org.eclipse.lsp4mp.ls/src/main/java/org/eclipse/lsp4mp/services/properties/PropertiesFileValidator.java#L195C1-L269C3 |
Signed-off-by: Fred Bricon <[email protected]>
|
SonarCloud Quality Gate failed.
|
angelozerr
reviewed
Sep 1, 2023
| return settings; | ||
| } | ||
|
|
||
| private Map<String, Object> getSeverityAndExclusions(DiagnosticSeverity severity, List<String> exclusions) { |
|
Great job @fbricon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with excluded unknown properties
Unassigned properties in Java files
