Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mark observer methods as implicitly used #1135

Merged
merged 1 commit into from
Sep 1, 2023
Merged

feat: Mark observer methods as implicitly used #1135

merged 1 commit into from
Sep 1, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Aug 31, 2023

@fbricon fbricon force-pushed the observerMethod-implicitUsage branch from d8f4c77 to d926ffa Compare August 31, 2023 15:44
gastaldi
gastaldi approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@fbricon fbricon force-pushed the observerMethod-implicitUsage branch from d926ffa to 3f93b69 Compare August 31, 2023 15:45
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
28.3% 28.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@angelozerr angelozerr merged commit 9b9fc6a into redhat-developer:main Sep 1, 2023
11 of 12 checks passed
@angelozerr
Copy link
Contributor

Thanks @fbricon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark observer methods as implicitly used
3 participants
@fbricon @angelozerr @gastaldi