Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ResponseErrorException when Ctrl+Hover due to cancellation #1137

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

angelozerr
Copy link
Contributor

fix: ResponseErrorException when Ctrl+Hover due to cancellation

Fixes #1136

@@ -52,15 +54,16 @@ public List<MarkupContent> getHoverContent(PsiElement element, int targetOffset,
// The LSP hover request are finished, don't need to cancel the previous LSP requests.
previousCancellationSupport = null;
return result;
} catch (ExecutionException e) {
if (!(e.getCause() instanceof CancellationException)) {
} catch (ResponseErrorException | ExecutionException | CancellationException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't CancellationExceptions be rethrown?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, because I think IJ will log this error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so throw it as ProcessCanceledException?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honnest with you, I don't know how IJ documentation is working and I don't know if ProcessCanceledException will be logged as an error or used for a particular behavior (ex: retry the hover).

My PR should keep the current behavior. We could investigate more in a separate PR i fthrowing ProcessCanceledException could be interesting.

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fbricon fbricon merged commit 20306d5 into redhat-developer:main Sep 1, 2023
12 checks passed
@fbricon
Copy link
Contributor

fbricon commented Sep 1, 2023

Thanks @angelozerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResponseErrorException when Ctrl+Hover due to cancellation
2 participants