Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disambiguate Quarkus launch config #1142

Merged
merged 1 commit into from
Sep 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@

public class QuarkusRunConfiguration extends ModuleBasedConfiguration<RunConfigurationModule, QuarkusRunConfigurationOptions> {
private final static Logger LOGGER = LoggerFactory.getLogger(QuarkusRunConfiguration.class);
private static final String QUARKUS_CONFIGURATION = "Quarkus Configuration";

private int port = 5005;

Expand Down Expand Up @@ -91,15 +92,15 @@ protected QuarkusRunConfigurationOptions getOptions() {
@Override
public void checkConfiguration() throws RuntimeConfigurationException {
if (getModule() == null) {
throw new RuntimeConfigurationException("No module selected", "Quarkus configuration");
throw new RuntimeConfigurationException("No module selected", QUARKUS_CONFIGURATION);
}
Module module = getModule();
if (!QuarkusModuleUtil.isQuarkusModule(module)) {
throw new RuntimeConfigurationException("Not a Quarkus module", "Quarkus configuration");
throw new RuntimeConfigurationException("Not a Quarkus module", QUARKUS_CONFIGURATION);
}
ToolDelegate delegate = ToolDelegate.getDelegate(module);
if (delegate == null) {
throw new RuntimeConfigurationException("Can't find a tool to process the module", "Quarkus configuration");
throw new RuntimeConfigurationException("Can't find a tool to process the module", QUARKUS_CONFIGURATION);
}
}

Expand Down Expand Up @@ -145,7 +146,7 @@ public RunProfileState getState(@NotNull Executor executor, @NotNull ExecutionEn
}
telemetry.send();
if (executor.getId() == DefaultDebugExecutor.EXECUTOR_ID) {
ProgressManager.getInstance().run(new Task.Backgroundable(getProject(), "Quarkus configuration", false) {
ProgressManager.getInstance().run(new Task.Backgroundable(getProject(), QUARKUS_CONFIGURATION, false) {
@Override
public void run(@NotNull ProgressIndicator indicator) {
createRemoteConfiguration(indicator);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ public class QuarkusRunConfigurationType implements ConfigurationType {
@NotNull
@Override
public String getDisplayName() {
return "Quarkus";
return "Quarkus Dev Mode";
}

@Nls
@Override
public String getConfigurationTypeDescription() {
return "Quarkus run configuration";
return "Quarkus Dev mode run configuration";
}

@Override
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/META-INF/pluginIcon_dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading