-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validate if a BuildItem is final
or abstract
#1171
feat: Validate if a BuildItem is final
or abstract
#1171
Conversation
Do you think you could provide code action to insert abstract / final keyword, or perhaps in an another PR? |
...evtools/intellij/quarkus/psi/internal/validators/QuarkusBuildItemDiagnosticsParticipant.java
Outdated
Show resolved
Hide resolved
b3c5716
to
8b68b89
Compare
...evtools/intellij/quarkus/psi/internal/validators/QuarkusBuildItemDiagnosticsParticipant.java
Show resolved
Hide resolved
@fbricon doyou think you could provide a test with this new validator? |
8b68b89
to
df926d9
Compare
Added some tests |
maybe another PR |
OK please create an issue to avoid forgetting to implement this code action |
df926d9
to
26e6420
Compare
src/test/java/com/redhat/devtools/intellij/quarkus/validation/BuildItemDiagnosticsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/redhat/devtools/intellij/quarkus/validation/BuildItemDiagnosticsTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Fred Bricon <[email protected]>
26e6420
to
67e1068
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Thanks @fbricon ! |
Validate if a BuildItem is
final
orabstract
cc @gastaldi
Fixes #1120
I still need to write tests