Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Validate if a BuildItem is final or abstract #1171

Merged
merged 1 commit into from
Sep 18, 2023
Merged

feat: Validate if a BuildItem is final or abstract #1171

merged 1 commit into from
Sep 18, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Sep 15, 2023

Validate if a BuildItem is final or abstract

Screenshot 2023-09-15 at 11 11 50

cc @gastaldi

Fixes #1120

I still need to write tests

@angelozerr
Copy link
Contributor

Do you think you could provide code action to insert abstract / final keyword, or perhaps in an another PR?

@angelozerr angelozerr mentioned this pull request Sep 15, 2023
Closed
@fbricon fbricon force-pushed the buildItem-validation branch 4 times, most recently from b3c5716 to 8b68b89 Compare September 15, 2023 13:32
@angelozerr
Copy link
Contributor

@fbricon doyou think you could provide a test with this new validator?

@fbricon fbricon marked this pull request as ready for review September 15, 2023 16:47
@fbricon
Copy link
Contributor Author

fbricon commented Sep 15, 2023

Added some tests

@fbricon
Copy link
Contributor Author

fbricon commented Sep 15, 2023

Do you think you could provide code action to insert abstract / final keyword, or perhaps in an another PR?

maybe another PR

@angelozerr
Copy link
Contributor

maybe another PR

OK please create an issue to avoid forgetting to implement this code action

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
15.6% 15.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@angelozerr angelozerr merged commit 9c95979 into redhat-developer:main Sep 18, 2023
11 of 12 checks passed
@angelozerr
Copy link
Contributor

Thanks @fbricon !

@angelozerr angelozerr mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelozerr angelozerr angelozerr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate if a BuildItem is final or abstract
2 participants
@fbricon @angelozerr