Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow language servers in light edit mode #1245

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Oct 30, 2023

  • don't use smart mode when in light edit
  • added new supportsLightEdit property to LS definitions, so some LS can be allowed in Light Edit mode. Disabled by default, so no Quarkus nor Qute LS are spawned in Light Edit mode

Fixes #1244

To test this fix, you need to install the corresponding build in the IDEA installation used to open a java file on double-click, or via idea <filename>.java in a terminal

@angelozerr
Copy link
Contributor

ConnectDocumentToLanguageServerSetupParticipant is used to force the connection to LS when file is opened to avoid starting ls when LSP operations like codelens, highlights etc occurs to avoid performance problem when several LSP operations occurs.

I wonder if correct fix should be done in

var executeInSmartMode = DumbService.getInstance(project).isDumb();
by checking light edit mode too?

Copy link

sonarcloud bot commented Nov 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.8% 4.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@fbricon fbricon merged commit cf3205e into redhat-developer:main Nov 6, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a Java file with IDEA (dbl-click on file) causes an exception
2 participants