Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy 'Run launch' tasks to the Maven run configuration #1262

Merged

Conversation

alerosmile
Copy link
Contributor

@alerosmile alerosmile commented Nov 9, 2023

The 'Before launch' tasks are configured in the QuarkusRunConfiguration. The must be added to the MavenRunConfiguration and GradleRunConfiguration, which are the ones which are actually executed.

Fixes #1259

The 'Before launch' tasks are configured in the QuarkusRunConfiguration. The must be added to the MavenRunConfiguration and GradleRunConfiguration, which are the ones which are actually executed.
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alerosmile
Copy link
Contributor Author

Fixes #1259

@angelozerr
Copy link
Contributor

Thanks @alerosmile !

LGTM, @fbricon @jeffmaury what do you think with this fix?

@fbricon fbricon self-requested a review November 9, 2023 14:07
@fbricon fbricon merged commit 95f8798 into redhat-developer:main Nov 9, 2023
10 checks passed
@fbricon
Copy link
Contributor

fbricon commented Nov 9, 2023

With this PR, the Build task is indeed executed before the launch.

I also tried the Open Browser task, to open http://localhost:8080, and this one runs after the launch, which is awesome! (maybe we could add a setting to add that task by default)

Nice work @alerosmile, thanks!

@alerosmile alerosmile deleted the runconfig-addrunbeforetasks branch November 9, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run configuration 'Before launch' does not work
3 participants