fix: Copy 'Run launch' tasks to the Maven run configuration #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'Before launch' tasks are configured in the QuarkusRunConfiguration. The must be added to the MavenRunConfiguration and GradleRunConfiguration, which are the ones which are actually executed.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Fixes #1259 |
|
Thanks @alerosmile ! LGTM, @fbricon @jeffmaury what do you think with this fix? |
|
With this PR, the Build task is indeed executed before the launch. I also tried the Open Browser task, to open http://localhost:8080, and this one runs after the launch, which is awesome! (maybe we could add a setting to add that task by default) Nice work @alerosmile, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Before launch' tasks are configured in the QuarkusRunConfiguration. The must be added to the MavenRunConfiguration and GradleRunConfiguration, which are the ones which are actually executed.
Fixes #1259