feat: More checks for return types from GraphQL operations #1275
Conversation
jmartisk
commented
Nov 28, 2023
•
jmartisk
commented
jmartisk
changed the title
|
@jmartisk many thanks for your contribution! Could youp please add a screenshot in your PR which shows in action your contribution. Thanks! |
|
@angelozerr done, added two screenshots in the description |
...om/redhat/devtools/intellij/lsp4mp4ij/psi/internal/graphql/MicroProfileGraphQLConstants.java
Show resolved
Hide resolved
| @@ -23,10 +23,12 @@ private MicroProfileGraphQLConstants() { | |||
|
|
|||
| public static final String QUERY_ANNOTATION = "org.eclipse.microprofile.graphql.Query"; | |||
| public static final String MUTATION_ANNOTATION = "org.eclipse.microprofile.graphql.Mutation"; | |||
| public static final String SUBSCRIPTION_ANNOTATION = "org.eclipse.microprofile.graphql.Subscription"; | |||
| public static final String SUBSCRIPTION_ANNOTATION = "io.smallrye.graphql.api.Subscription"; | |||
There was a problem hiding this comment.
SMALLRYE_SUBSCRIPTION_ANNOTATION
There was a problem hiding this comment.
Let's keep it as SUBSCRIPTION_ANNOTATION for now as there is no microprofile annotation for it
jmartisk
force-pushed
the
graphql-operation-return-types
branch
from
046fcb2
to
aaae4ee
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @fbricon I noticed this has been waiting for a long time, could you give it another look, and let me know if anything else is needed before merging? Thanks |
|
Thanks @jmartisk, sorry for the delay in handling this one. |
