Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: replace remark with flexmark #1298

Merged
merged 1 commit into from
Dec 21, 2023
Merged

build: replace remark with flexmark #1298

merged 1 commit into from
Dec 21, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Dec 19, 2023 •
edited
Loading

Replaces obsolete, unmaintained, unsecure remark with flexmark.

Fixes an issue with documentation always being returned as plaintext instead of markdown.

Works best with redhat-developer/lsp4ij#59

@fbricon fbricon added the build label Dec 19, 2023
@fbricon fbricon added this to the 1.31.0 milestone Dec 19, 2023
@fbricon fbricon force-pushed the flexmark branch 2 times, most recently from ae99a24 to 044d4fd Compare December 20, 2023 14:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

4.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@angelozerr angelozerr merged commit 3dd00d1 into redhat-developer:main Dec 21, 2023
7 of 8 checks passed
@angelozerr
Copy link
Contributor

Thanks @fbricon !

@fbricon fbricon modified the milestones: 1.31.0, 1.31.1 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fbricon @angelozerr