Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update minimum required IJ version to 2023.1 #1310

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Jan 31, 2024

This fixes an issue when running the plugin in IJ 2024.1 EAP:

com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. ‘com.redhat.devtools.lsp4ij.console.actions.AutoFoldingAction’ must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: com.redhat.devtools.lsp4ij]
	at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
	at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:90)
	at com.intellij.diagnostic.PluginException.reportDeprecatedUsage(PluginException.java:125)
	at com.intellij.openapi.actionSystem.ActionUpdateThreadAware.getActionUpdateThread(ActionUpdateThreadAware.java:21)
	at com.intellij.openapi.actionSystem.AnAction.getActionUpdateThread(AnAction.java:198)

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@fbricon fbricon changed the title build: update minimum required IJ version to 2022.3 build: update minimum required IJ version to 2023.1 Mar 19, 2024
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@angelozerr angelozerr merged commit e45b630 into redhat-developer:main Mar 21, 2024
4 of 8 checks passed
@angelozerr
Copy link
Contributor

Thanks so much @fbricon !

@rongyanjuren
Copy link

我们需要支持19.3版本,除了这种方式还有其他方式吗?@fbricon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants