Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error while adding QuarkusRunConfigurationType in Services view settings #1330

Conversation

angelozerr
Copy link
Contributor

fix: Error while adding QuarkusRunConfigurationType in Services view settings

Fixes #1299, #1323

This PR uses the RunDashboardDefaultTypesProvider extension point to add automaticlly the Quarkus Run config type in the Services view when the option 'Create "Quarkus Dev Mode" run configuration on project import' is activated.

It avoids to add the Quarkus Run config type with the RunDashboardManager#setTypes which can causes many problems like

@angelozerr angelozerr force-pushed the quarkus-dashbord_add_type_with_extension branch from 103cdbb to 20a5bf8 Compare May 6, 2024 06:58
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fbricon fbricon merged commit 4547e29 into redhat-developer:main May 6, 2024
6 of 8 checks passed
@fbricon
Copy link
Contributor

fbricon commented May 6, 2024

thanks @angelozerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while adding QuarkusRunConfigurationType in Services view settings
2 participants