-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Formatting is broken when using simple {} #1347
Conversation
@ia3andy we have a bug with the Qute IntelliJ parser that I have fixed (need to play more with this fix and need to write tests for this Qute IntelliJ parser). The fix allows to consider that Qute section tag are closed correctly and now it is considered as HTML Text node. With the fix:, HTML element should be correctly indented, but as Qute section as considered as HTML Text node, the section cannot be indented, is it annoying? Given this Qute template: <div>
<div>
{#if}
{#if}
{inject:flash.get("key")}
<form>
</form>
{/if}
{/if}
</div>
</div> After formatting: <div>
<div>
{#if}
{#if}
{inject:flash.get("key")}
<form>
</form>
{/if}
{/if}
</div>
</div>
Indenting Qute section is not trivial to do, we could do that in an another PR, but @ia3andy do you think it is enough for you? |
It's perfect 🤩 please make it available for 8 of July :) |
@ia3andy you can play with this PR by downloading thezip at https://github.com/redhat-developer/intellij-quarkus/actions/runs/9722616563, see expalanation at https://github.com/redhat-developer/intellij-quarkus?tab=readme-ov-file#testing-the-ci-builds It should install https://plugins.jetbrains.com/plugin/23257-lsp4ij/edit too I think otherwise you will need to install it. |
ok will there be a release before 8 of july? (I have a lab) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a new release with this in please 🙄 |
98bedac
to
d6457a3
Compare
Fixes redhat-developer#1345 Signed-off-by: azerr <[email protected]>
That's great! Thanks @ia3andy for your patience and to have tested the IJ plugin of my PR. |
fix: Formatting is broken when using simple {}
Fixes #1345