fix: allow inject: with constructor class which have arguments #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: azerr <[email protected]>
angelozerr
force-pushed
the
allow_inject_constructor_args
branch
from
d93d5ee
to
18968ee
Compare
|
@fbricon this PR has now a test. |
|
The CI build fails because of integration tests, but I think we can merge it. |
|
Thanks @angelozerr! Now the same fix needs to be applied in the JDT implem. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open https://github.com/ia3andy/one-two-three-quarkus/blob/main/dashboard/src/main/resources/templates/main.html
You will see a false positive error with
inject:csrf:inject:csrfcomes from https://github.com/quarkusio/quarkus/blob/e46f2ec5588858525634e42fa1c6146162ade461/extensions/resteasy-reactive/rest-csrf/runtime/src/main/java/io/quarkus/csrf/reactive/runtime/CsrfTokenParameterProvider.java#L13This class is flagged because it has constructor arguments https://github.com/quarkusio/quarkus/blob/e46f2ec5588858525634e42fa1c6146162ade461/extensions/resteasy-reactive/rest-csrf/runtime/src/main/java/io/quarkus/csrf/reactive/runtime/CsrfTokenParameterProvider.java#L27
Quarkus manages this arguments injection, so the
inject:csrfmust be valid.This PR fix the issue:
inject:csrfdoesn't report errorinject:csrfshould work now://cc @ia3andy