fix: Perform updates to Stop Language Server Timer synchronously. (#905) #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
ls-stopping-timer
branch
from
4e0ae8e
to
a4a8aad
Compare
fbricon
approved these changes
Jun 1, 2023
angelozerr
force-pushed
the
ls-stopping-timer
branch
2 times, most recently
from
955c5f3
to
5f9a847
Compare
Fixes #905 Signed-off-by: azerr <[email protected]>
|
Please don't merge, I have seen some trouble when we start stop ls, close files. I will investigate the problem when I will have time. More there is a problem with thread lock in test https://github.com/redhat-developer/intellij-quarkus/actions/runs/5144122828/jobs/9260013480?pr=906#step:5:463 I think this PR is not very important for now. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Perform updates to Stop Language Server Timer synchronously. (#905)
Fixes redhat-developer/lsp4ij#18