fix: set proper borders / alignment in quarkus wizard #969
Conversation
|
For the Filter extension field (in last wizard page) I will grow up the field size to take the full horizontal size of the page. It is not linked to this issue but I have noticed that click on Next button is slow. I think it is because it collect Quarkus extension, but I think we should manage a progress monitor or something like this which explains that Quarkus extensions are collected. At first I though it didn't work and click on Next button several times. |
Signed-off-by: Fred Bricon <[email protected]>
fbricon
force-pushed
the
fix-wizard-margins
branch
from
12ed118
to
5064d08
Compare
| Dimension maxSize = super.getMaximumSize(); | ||
| return new Dimension(maxSize.width, JBUI.scale(30)); |
There was a problem hiding this comment.
Made the filter field fill the horizontal space:
|
added a commit which removes it: |
Signed-off-by: Andre Dietisheim <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@adietish definitely too much space, I spent some time trying to fix it already, but IMHO this requires rewriting the QuarkusModuleBuilder so it doesn't extend JavaModuleBuilder, so we can control the layout of the SDK field. I chose to ignore that in this PR for now, it will need to be addressed separately. |
I was actually thinking more of the SDK left alignment, more than the space below |
|
@adietish thanks |
fixes #636
fixes #637