feat: improve LSP settings UI #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fred Bricon <[email protected]>
|
@fbricon, @angelozerr: I'm fixing the vertical gap and the missing indentation for the controls. If you want to use a group with a title, all controls below it have to be indented, not just the comment like it is in this PR. 
See here as example: |
|
Working around stuff too but I think that I got it finally. I still have a small vertical gap btw. title and description that I can't get rid off (it's smaller than before though) |
|
@fbricon, @angelozerr: please review |
Signed-off-by: Andre Dietisheim <[email protected]>
adietish
force-pushed
the
improve-server-settings
branch
from
044af2d
to
1fa7111
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
adietish
approved these changes
Jun 26, 2023
|
@adietish thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #861
However I spent an unreasonable amount of time trying to fix the wide margin between the title and the comment, but no dice. Still looks better than before (#861) so I gave up.
Signed-off-by: Fred Bricon [email protected]