Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extracted methods to improve readability #978

Merged

Conversation

adietish
Copy link
Contributor

No description provided.

@adietish adietish requested a review from angelozerr June 27, 2023 13:23
@angelozerr
Copy link
Contributor

@adietish could you do the same pat h that you did for LSPCodelensInlayHintProvider.

Could you fix commit too. Thanks!

@adietish adietish force-pushed the refactor_improve_readability branch from 3835cac to fbf8c68 Compare June 28, 2023 14:15
@adietish
Copy link
Contributor Author

@angelozerr: done, please review

@adietish adietish force-pushed the refactor_improve_readability branch from fbf8c68 to 6b893ef Compare June 28, 2023 14:17
@adietish adietish changed the title extracted methods to improve readability refactor: extracted methods to improve readability Jun 29, 2023
@adietish adietish force-pushed the refactor_improve_readability branch from 6b893ef to f8890f6 Compare June 29, 2023 08:56
@adietish adietish self-assigned this Jun 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@angelozerr angelozerr added this to the 1.22.0 milestone Jun 29, 2023
@angelozerr angelozerr merged commit 453a142 into redhat-developer:main Jun 29, 2023
11 of 12 checks passed
@angelozerr
Copy link
Contributor

Thanks so much @adietish !

@adietish adietish deleted the refactor_improve_readability branch June 29, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants