Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: map LSP4J CompletionItemKinds to Intellij IDEA icons #985

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Jun 29, 2023

Provides icons for completion results.

"recent" icons from IJ were copied over to work with older IJ versions still supported.

Example for application.properties completion:

Screenshot 2023-06-28 at 20 41 18

@fbricon fbricon added enhancement New feature or request completion labels Jun 29, 2023
@fbricon fbricon force-pushed the icon-mapping branch 2 times, most recently from 7f7c391 to 0fe1dc4 Compare June 29, 2023 10:19
@fbricon
Copy link
Contributor Author

fbricon commented Jun 29, 2023

example of qute completion:
Screenshot 2023-06-29 at 14 51 29

@fbricon
Copy link
Contributor Author

fbricon commented Jun 29, 2023

Example of snippets
Screenshot 2023-06-29 at 15 04 00

@angelozerr
Copy link
Contributor

Nice PR! +1

}

@Override
public void renderElement(LookupElementPresentation presentation) {
presentation.setItemText(item.getLabel());
presentation.setTypeText(item.getDetail());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item detail now added to the type text:

Screenshot 2023-06-29 at 15 22 50 Screenshot 2023-06-29 at 15 25 00

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@angelozerr
Copy link
Contributor

It works like a charm. Thanks @fbricon !

@angelozerr angelozerr merged commit 795b56e into redhat-developer:main Jun 29, 2023
@angelozerr angelozerr added this to the 1.22.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completion enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants