Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add E2E test workflow #108

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

odockal
Copy link
Contributor

@odockal odockal commented Apr 16, 2024

Adding workflow that runs e2e test suite (#76) after push to merge event and on demand. It does not replace PR check that will be added as well.

@odockal odockal requested a review from a team as a code owner April 16, 2024 12:27
@odockal odockal requested review from benoitf, dgolovin and feloy April 16, 2024 12:27
@odockal
Copy link
Contributor Author

odockal commented Apr 16, 2024

@cbr7 If you would please take a look.

@odockal
Copy link
Contributor Author

odockal commented Apr 16, 2024

Fixes #107

.github/workflows/e2e-main.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-main.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-main.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-main.yaml Show resolved Hide resolved
run: yarn test:e2e

- uses: actions/upload-artifact@v4
if: always()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me that working-directory: ./podman-desktop-redhat-account-ext is missing here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. let me check bootc version. given the glob pattern, it might still works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nice in bootc: https://github.com/containers/podman-desktop-extension-bootc/actions/runs/8742851050 even without specifying working dir of the ext.

with:
repository: ${{ github.event.inputs.organization }}/${{ github.event.inputs.repositoryName }}
ref: ${{ github.event.inputs.branch }}
path: ${{ github.event.inputs.repositoryName }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the path maybe different (see line 93)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point now. That needs to be fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the step at line 60. I am now using dynamic repository name resolution based on event that triggers the workflow. Variable is used for working-directory now.

Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odockal odockal merged commit ae07904 into redhat-developer:main Apr 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants