-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add E2E test workflow #108
Conversation
@cbr7 If you would please take a look. |
Fixes #107 |
run: yarn test:e2e | ||
|
||
- uses: actions/upload-artifact@v4 | ||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to me that working-directory: ./podman-desktop-redhat-account-ext
is missing here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question. let me check bootc version. given the glob pattern, it might still works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works nice in bootc: https://github.com/containers/podman-desktop-extension-bootc/actions/runs/8742851050 even without specifying working dir of the ext.
with: | ||
repository: ${{ github.event.inputs.organization }}/${{ github.event.inputs.repositoryName }} | ||
ref: ${{ github.event.inputs.branch }} | ||
path: ${{ github.event.inputs.repositoryName }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the path maybe different (see line 93)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point now. That needs to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the step at line 60. I am now using dynamic repository name resolution based on event that triggers the workflow. Variable is used for working-directory now.
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
Signed-off-by: Ondrej Dockal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding workflow that runs e2e test suite (#76) after push to merge event and on demand. It does not replace PR check that will be added as well.