fix(fab): fixing css issues #427
Conversation
Signed-off-by: its-mitesh-kumar <[email protected]>
its-mitesh-kumar
requested review from
christoph-jerolimov,
ciiay,
debsmita1,
divyanshiGupta and
gashcrumb
as code owners
Changed Packages
|
Signed-off-by: its-mitesh-kumar <[email protected]>
There was a problem hiding this comment.
Hi @its-mitesh-kumar, can you please add screenshots before and after to your PR.
| textTransform: 'lowercase', // Convert entire text to lowercase | ||
| '&::first-letter': { | ||
| textTransform: 'uppercase', // Capitalize first letter | ||
| }, |
There was a problem hiding this comment.
I don't think we should transform the label at all, and esp this way. The only option I see is that we want reset the default transformation.
There was a problem hiding this comment.
As per requirement Change the FAB text to sentence case, ex: "Bulk import" instead of "BULK IMPORT" , we need to transform the label , yes better to do with javascript .
There was a problem hiding this comment.
Yes and no. Maybe the wording wasn't exact. But instead of applying another set of text transform we should use no text transform here. Which means a simple textTransform: 'unset'
MUI by default converts all Buttons with text-transform to uppercase. With PatternFly we don't follow this rule.
In best case, we would fix that (override this default text-transform rule) in our theme. If customers want use the MUI theme, or their own theme, it should be up to the theme if the button is "UPPERCASE" or "Normal Case".
But there is no general rule how to handle for example this buttons:
- Create a ticket
- ServiceNow
- Open RHDH documentation
MUI solution works because it simple says everything is uppercase.
Our goal is that we want keep what the user (admin) configures.
If you like, you can also take a look into the theme. But with our short timeframe its also fine to apply it (first) here. I would prefer later a theme solution and remove this special rule here again.
There was a problem hiding this comment.
@debsmita1 just fyi, I didn't reviewed the rest of the changes. :)
There was a problem hiding this comment.
@christoph-jerolimov I'm updating textTransform to 'unset'. Should we also create a ticket for the theme changes?
updated the FAB menu actions
Revert "updated the FAB menu actions"
…bal-fab Revert "Revert "updated the FAB menu actions""
Signed-off-by: its-mitesh-kumar <[email protected]>
|
|
@ShiranHi @debsmita1 isux looks fine for you . screen-recording-2025-02-25-at-125803-am_ZGkdaWoL.mp4 |
Upload.Fab.mov
Fixes https://issues.redhat.com/browse/RHIDP-5482