Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lightspeed): remove resets from PF CSS import #469

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

logonoff
Copy link
Contributor

@logonoff logonoff commented Mar 4, 2025

Fixes https://issues.redhat.com/browse/RHIDP-5575

Hey, I just made a Pull Request!

remove resets from PF CSS import per discussion with @christoph-jerolimov and @benwilcock. Thanks @christoph-jerolimov for spotting the bug :)

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Mar 4, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed patch v0.4.0

@logonoff
Copy link
Contributor Author

logonoff commented Mar 4, 2025

replaces #434 as I renamed the branch

@christoph-jerolimov
Copy link
Member

Thanks @logonoff 👍

/cc @karthikjeeyar @rohitkrai03

@karthikjeeyar
Copy link
Member

karthikjeeyar commented Mar 5, 2025

This change impacts the chatbot layout.

Before:
image

After:
With base-no-reset.css, there is an extra padding in the header, chat history panel
image

@christoph-jerolimov
Copy link
Member

Hey @logonoff, can you check if you can test and fix that layout in the dev page? I guess removing the extra spacing from the header is the only issue here, @karthikjeeyar?

@logonoff
Copy link
Contributor Author

This change impacts the chatbot layout.

Before: image

After: With base-no-reset.css, there is an extra padding in the header, chat history panel image

Just fixed the alignment of the header!

image

@karthikjeeyar
Copy link
Member

Thanks @logonoff for fixing the header. The extra padding issue is also with the list items in the chat history panel

image

Copy link
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow up, looks good to me.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 13, 2025
@karthikjeeyar karthikjeeyar merged commit 5d5904b into redhat-developer:main Mar 13, 2025
9 checks passed
@logonoff logonoff deleted the lightspeed-css branch March 13, 2025 04:35
@christoph-jerolimov
Copy link
Member

Thanks @logonoff and @karthikjeeyar

@karthikjeeyar can you please update your lightning plugin build on quay and share this with @benwilcock. I hope this fixes his issue that the markdown cards on the homepage was unstyled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants