-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lightspeed): remove resets from PF CSS import #469
Conversation
Changed Packages
|
replaces #434 as I renamed the branch |
Thanks @logonoff 👍 |
Hey @logonoff, can you check if you can test and fix that layout in the dev page? I guess removing the extra spacing from the header is the only issue here, @karthikjeeyar? |
Thanks @logonoff for fixing the header. The extra padding issue is also with the list items in the chat history panel |
f0358a0
to
ac7434b
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the follow up, looks good to me.
/lgtm
Thanks @logonoff and @karthikjeeyar @karthikjeeyar can you please update your lightning plugin build on quay and share this with @benwilcock. I hope this fixes his issue that the markdown cards on the homepage was unstyled. |
Fixes https://issues.redhat.com/browse/RHIDP-5575
Hey, I just made a Pull Request!
remove resets from PF CSS import per discussion with @christoph-jerolimov and @benwilcock. Thanks @christoph-jerolimov for spotting the bug :)
✔️ Checklist