feat(adoption-insights): add grouping configuration in insights endpoints. #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
karthikjeeyar
force-pushed
the
add-grouping-config
branch
from
f3fec5a to
d9f50cc
Compare
|
|
Pulled the changes to my local and tested it. Everything /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://issues.redhat.com/browse/RHDHPAI-658
This PR contains following changes:
groupingquery param configuration to provide fine grain control to the consumers. Now users can explicitly fetch the queries based on their need, if not then backend will choose them a better grouping strategy based on the date interval.hourlygrouping strategy to get data points for every hour in a day.Screenshots:
unit tests:
✔️ Checklist