chore(e2e): refactor periodic pipeline to include sanity plugins check #2248

gustavolira · 2025-01-24T17:33:56Z

Reintegrates the "add_sanity_plugins_check" step into the periodic pipeline.

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

GitHub Actions are completed and successful
Unit Tests are updated and passing
E2E Tests are updated and passing
Documentation is updated if necessary (requirement for new features)
Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

gustavolira · 2025-01-24T21:17:36Z

/retest-required

gustavolira · 2025-01-29T22:46:57Z

/test e2e-tests

gustavolira · 2025-01-29T23:35:04Z

/test e2e-tests

github-actions · 2025-01-30T00:35:59Z

The image is available at:

github-actions · 2025-02-01T01:25:53Z

The image is available at:

gustavolira · 2025-02-01T16:47:53Z

/test e2e-tests

github-actions · 2025-02-16T02:04:05Z

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

openshift-ci · 2025-02-17T22:10:49Z

@gustavolira: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/periodic-e2e-tests-gke-helm-nightly	`938f7f3`	link	false	`/test periodic-e2e-tests-gke-helm-nightly`
ci/prow/periodic-e2e-tests-aks-helm-nightly	`938f7f3`	link	false	`/test periodic-e2e-tests-aks-helm-nightly`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

e2e-tests/playwright.config.ts

zdrapela · 2025-02-18T06:34:54Z

e2e-tests/playwright.config.ts

@@ -154,5 +166,15 @@ export default defineConfig({
        "**/playwright/e2e/verify-tls-config-health-check.spec.ts",
      ],
    },
+


You have to add the

"**/playwright/e2e/audit-log/**/*.spec.ts",

To testIgnore for showcase project

@zdrapela @gustavolira why to ignore this audit log tests? isn't it expected to run in showcase?

I suppose that @gustavolira intentionally moved it to a separate namespace that runs only on nightly. Is that correct @gustavolira?

are you talking about showcase-sanity-plugins namespace?
I dont see audit log test here :
name: "showcase-sanity-plugins", testMatch: [ "**/playwright/e2e/catalog-timestamp.spec.ts", "**/playwright/e2e/plugins/frontend/sidebar.spec.ts", "**/playwright/e2e/home-page-customization.spec.ts", "**/playwright/e2e/instance-health-check.spec.ts",

Oh, I'm not sure why I expected that audit-log is moved to sanity-plugins 😅 I will remove it from the testIgnore for showcase in this PR #2417

subhashkhileri · 2025-02-18T10:31:00Z

/test ?

openshift-ci · 2025-02-18T10:31:03Z

@subhashkhileri: The following commands are available to trigger required jobs:

/test e2e-tests

The following commands are available to trigger optional jobs:

/test cleanup-mapt-destroy-orphaned-aks-clusters

/test e2e-tests-aks-helm-nightly

/test e2e-tests-gke-helm-nightly

/test e2e-tests-nightly

/test e2e-tests-operator-nightly

/test e2e-tests-osd-gcp-helm-nightly

/test e2e-tests-osd-gcp-operator-nightly

Use /test all to run the following jobs that were automatically triggered:

pull-ci-redhat-developer-rhdh-main-e2e-tests

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

subhashkhileri · 2025-02-18T10:31:13Z

/test e2e-tests-nightly

.ibm/pipelines/jobs/periodic.sh

Signed-off-by: Gustavo Lira <[email protected]>

Moved plugin checks deployment logic to a reusable function `initiate_sanity_plugin_checks_deployment`. Simplified the `run_sanity_plugins_check` method by delegating complex deployment steps to the new function, improving readability and maintainability. Signed-off-by: Gustavo Lira <[email protected]>

zdrapela

Thanks for the refactor! Since the nightly job passed here, I assume it is good to go: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-developer_rhdh/2248/pull-ci-redhat-developer-rhdh-main-e2e-tests-nightly/1891797622285406208/artifacts/e2e-tests-nightly/redhat-developer-rhdh-nightly/artifacts/showcase-sanity-plugins/index.html

zdrapela · 2025-02-18T14:16:00Z

/test e2e-tests-nightly

zdrapela · 2025-02-18T14:16:07Z

/lgtm

openshift-ci · 2025-02-18T14:16:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdrapela

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~.ibm/OWNERS~~ [zdrapela]
~~e2e-tests/OWNERS~~ [zdrapela]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

redhat-developer#2248) * Add temporary plugin configurations for sandbox setup * Add sanity plugins check to pipeline scripts and tests Signed-off-by: Gustavo Lira <[email protected]> * Remove default JOB_NAME export from CI test script Signed-off-by: Gustavo Lira <[email protected]> * Add audit log tests and remove commented-out config Signed-off-by: Gustavo Lira <[email protected]> * Refactor periodic sanity plugin checks deployment logic Moved plugin checks deployment logic to a reusable function `initiate_sanity_plugin_checks_deployment`. Simplified the `run_sanity_plugins_check` method by delegating complex deployment steps to the new function, improving readability and maintainability. Signed-off-by: Gustavo Lira <[email protected]> --------- Signed-off-by: Gustavo Lira <[email protected]>

openshift-ci bot requested review from subhashkhileri and zdrapela January 24, 2025 17:34

gustavolira force-pushed the RHIDP-5696 branch 3 times, most recently from 6e56c65 to 0ffb83c Compare January 28, 2025 11:49

openshift-merge-robot added the needs-rebase label Jan 28, 2025

gustavolira force-pushed the RHIDP-5696 branch from a15dee4 to 1934984 Compare January 29, 2025 14:06

openshift-merge-robot removed the needs-rebase label Jan 29, 2025

gustavolira force-pushed the RHIDP-5696 branch from 1934984 to 05fd325 Compare January 29, 2025 17:31

gustavolira force-pushed the RHIDP-5696 branch from 6261b0a to b6de9dc Compare January 29, 2025 23:58

gustavolira force-pushed the RHIDP-5696 branch 4 times, most recently from f9acd07 to 3cf39c6 Compare February 1, 2025 00:52

gustavolira force-pushed the RHIDP-5696 branch from 3cf39c6 to 1c8bd7d Compare February 1, 2025 11:55

gustavolira force-pushed the RHIDP-5696 branch 2 times, most recently from f70a626 to 13ab0e1 Compare February 4, 2025 13:14

openshift-merge-robot added the needs-rebase label Feb 8, 2025

github-actions bot added the Stale label Feb 16, 2025

gustavolira force-pushed the RHIDP-5696 branch from 13ab0e1 to 5cf7726 Compare February 17, 2025 18:04

openshift-merge-robot removed the needs-rebase label Feb 17, 2025

github-actions bot removed the Stale label Feb 18, 2025

zdrapela suggested changes Feb 18, 2025

View reviewed changes

gustavolira force-pushed the RHIDP-5696 branch from aa37986 to 6cae0ce Compare February 18, 2025 12:12

zdrapela reviewed Feb 18, 2025

View reviewed changes

.ibm/pipelines/jobs/periodic.sh Show resolved Hide resolved

gustavolira added 5 commits February 18, 2025 11:09

Add temporary plugin configurations for sandbox setup

e351865

Add sanity plugins check to pipeline scripts and tests

65c631e

Signed-off-by: Gustavo Lira <[email protected]>

Remove default JOB_NAME export from CI test script

e4ef100

Signed-off-by: Gustavo Lira <[email protected]>

Add audit log tests and remove commented-out config

ab5ad6c

Signed-off-by: Gustavo Lira <[email protected]>

gustavolira force-pushed the RHIDP-5696 branch from 6cae0ce to e99f40b Compare February 18, 2025 14:09

zdrapela approved these changes Feb 18, 2025

View reviewed changes

openshift-ci bot added the approved label Feb 18, 2025

openshift-ci bot assigned zdrapela Feb 18, 2025

openshift-ci bot added the lgtm label Feb 18, 2025

openshift-merge-bot bot merged commit 76bdfa0 into redhat-developer:main Feb 18, 2025
12 checks passed

zdrapela mentioned this pull request Feb 19, 2025

chore(e2e): techdocs addons tests #2385

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(e2e): refactor periodic pipeline to include sanity plugins check #2248

chore(e2e): refactor periodic pipeline to include sanity plugins check #2248

gustavolira commented Jan 24, 2025

gustavolira commented Jan 24, 2025

gustavolira commented Jan 29, 2025

gustavolira commented Jan 29, 2025

github-actions bot commented Jan 30, 2025

github-actions bot commented Feb 1, 2025

gustavolira commented Feb 1, 2025

github-actions bot commented Feb 16, 2025

openshift-ci bot commented Feb 17, 2025 •

edited

Loading

zdrapela Feb 18, 2025

subhashkhileri Feb 19, 2025 •

edited

Loading

zdrapela Feb 19, 2025

subhashkhileri Feb 19, 2025

zdrapela Feb 19, 2025

subhashkhileri commented Feb 18, 2025

openshift-ci bot commented Feb 18, 2025

subhashkhileri commented Feb 18, 2025

zdrapela left a comment

zdrapela commented Feb 18, 2025

zdrapela commented Feb 18, 2025

openshift-ci bot commented Feb 18, 2025

chore(e2e): refactor periodic pipeline to include sanity plugins check #2248

chore(e2e): refactor periodic pipeline to include sanity plugins check #2248

Conversation

gustavolira commented Jan 24, 2025

Description

Which issue(s) does this PR fix

PR acceptance criteria

How to test changes / Special notes to the reviewer

gustavolira commented Jan 24, 2025

gustavolira commented Jan 29, 2025

gustavolira commented Jan 29, 2025

github-actions bot commented Jan 30, 2025

github-actions bot commented Feb 1, 2025

gustavolira commented Feb 1, 2025

github-actions bot commented Feb 16, 2025

openshift-ci bot commented Feb 17, 2025 • edited Loading

zdrapela Feb 18, 2025

Choose a reason for hiding this comment

subhashkhileri Feb 19, 2025 • edited Loading

Choose a reason for hiding this comment

zdrapela Feb 19, 2025

Choose a reason for hiding this comment

subhashkhileri Feb 19, 2025

Choose a reason for hiding this comment

zdrapela Feb 19, 2025

Choose a reason for hiding this comment

subhashkhileri commented Feb 18, 2025

openshift-ci bot commented Feb 18, 2025

subhashkhileri commented Feb 18, 2025

zdrapela left a comment

Choose a reason for hiding this comment

zdrapela commented Feb 18, 2025

zdrapela commented Feb 18, 2025

openshift-ci bot commented Feb 18, 2025

openshift-ci bot commented Feb 17, 2025 •

edited

Loading

subhashkhileri Feb 19, 2025 •

edited

Loading