Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fab wrapper #2355

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix: update fab wrapper #2355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions app-config.dynamic-plugins.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,13 +262,6 @@ dynamicPlugins:
mountPoints:
- mountPoint: application/listener
importName: DynamicGlobalFloatingActionButton
- mountPoint: global.floatingactionbutton/component
importName: NullComponent
config:
icon: github
label: Git
toolTip: Github
to: https://github.com/redhat-developer/rhdh
red-hat-developer-hub.backstage-plugin-dynamic-home-page:
dynamicRoutes:
- path: /
Expand Down
9 changes: 1 addition & 8 deletions dynamic-plugins.default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,21 +538,14 @@ plugins:

# Group: Global floating action button
- package: ./dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-global-floating-action-button
disabled: true
disabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default won't this be disabled?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin doesn't render anything by default. It "waits" that other plugins to use it. So this is fine.

pluginConfig:
dynamicPlugins:
frontend:
red-hat-developer-hub.backstage-plugin-global-floating-action-button:
mountPoints:
- mountPoint: application/listener
importName: DynamicGlobalFloatingActionButton
- mountPoint: global.floatingactionbutton/component
importName: NullComponent
config:
icon: github
label: 'Git'
toolTip: 'Github'
to: https://github.com/redhat-developer/rhdh

# Homepage
- package: ./dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-dynamic-home-page
Expand Down
4 changes: 2 additions & 2 deletions ...rappers/red-hat-developer-hub-backstage-plugin-global-floating-action-button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "red-hat-developer-hub-backstage-plugin-global-floating-action-button",
"version": "0.0.6",
"version": "1.0.0",
"main": "src/index.ts",
"types": "src/index.ts",
"license": "Apache-2.0",
Expand Down Expand Up @@ -29,7 +29,7 @@
},
"dependencies": {
"@mui/material": "5.16.14",
"@red-hat-developer-hub/backstage-plugin-global-floating-action-button": "0.0.6"
"@red-hat-developer-hub/backstage-plugin-global-floating-action-button": "1.0.0"
},
"devDependencies": {
"@backstage/cli": "0.29.6",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16132,9 +16132,9 @@ __metadata:
languageName: node
linkType: hard

"@red-hat-developer-hub/backstage-plugin-global-floating-action-button@npm:0.0.6":
version: 0.0.6
resolution: "@red-hat-developer-hub/backstage-plugin-global-floating-action-button@npm:0.0.6"
"@red-hat-developer-hub/backstage-plugin-global-floating-action-button@npm:1.0.0":
version: 1.0.0
resolution: "@red-hat-developer-hub/backstage-plugin-global-floating-action-button@npm:1.0.0"
dependencies:
"@backstage/core-components": ^0.16.3
"@backstage/core-plugin-api": ^1.10.3
Expand All @@ -16148,7 +16148,7 @@ __metadata:
peerDependencies:
react: 16.13.1 || ^17.0.0 || ^18.0.0
react-router-dom: ^6.0.0
checksum: 2c9f0046497b5f2f67f557078408bea951a897d0914aeb9a55b199c9a55dee094c0796438d23c4d092feb6b00ddf92dbd6494e5ff1b8a5285e7c31b928e40944
checksum: 59f339c5a243a9bd26beca69e15262a5f6ba7372b0d887d3fbcb937ea8d4bb508599071f537864dbcd5348cc48ed0246638f07cab21d286f924ceb6ae4cf0c53
languageName: node
linkType: hard

Expand Down Expand Up @@ -40218,7 +40218,7 @@ __metadata:
"@backstage/cli": 0.29.6
"@janus-idp/cli": 3.2.0
"@mui/material": 5.16.14
"@red-hat-developer-hub/backstage-plugin-global-floating-action-button": 0.0.6
"@red-hat-developer-hub/backstage-plugin-global-floating-action-button": 1.0.0
typescript: 5.7.3
languageName: unknown
linkType: soft
Expand Down
Loading