Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Bump k8s.io/api & friends to 0.27 #1462

Merged

Conversation

sadlerap
Copy link
Contributor

Changes

This bumps SBO's dependencies to their latest available versions. Since one of the dependencies of this version bump requires go v1.20 transitively, SBO's minumum go version has been bumped as well.

Fixes #1461.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1462 (f0affa7) into master (3529a8e) will decrease coverage by 0.06%.
The diff coverage is 55.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1462      +/-   ##
==========================================
- Coverage   58.21%   58.16%   -0.06%     
==========================================
  Files          35       35              
  Lines        3011     3014       +3     
==========================================
  Hits         1753     1753              
- Misses       1090     1093       +3     
  Partials      168      168              
Files Changed Coverage Δ
.../v1beta1/clusterworkloadresourcemapping_webhook.go 92.39% <0.00%> (ø)
apis/webhooks/admission.go 0.00% <0.00%> (ø)
pkg/reconcile/pipeline/context/application.go 64.10% <ø> (ø)
apis/binding/v1alpha1/servicebinding_webhook.go 65.38% <62.50%> (ø)
apis/spec/v1beta1/servicebinding_webhook.go 58.62% <62.50%> (ø)
apis/webhooks/validator.go 61.78% <90.00%> (ø)
...kg/reconcile/pipeline/context/spec_binding_impl.go 70.58% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3529a8e...f0affa7. Read the comment docs.

@sadlerap
Copy link
Contributor Author

/test 4.10-acceptance
/test 4.11-acceptance
/test 4.12-acceptance
/test 4.13-acceptance

Dockerfile Outdated Show resolved Hide resolved
This bumps SBO's dependencies to their latest available versions.  Since one of the dependencies of
this version bump requires go v1.20 transitively, SBO's minumum go version has been bumped as well.

Fixes redhat-developer#1461.

Signed-off-by: Andy Sadler <[email protected]>
@filariow
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4db996c into redhat-developer:master Jul 28, 2023
17 of 19 checks passed
@sadlerap sadlerap deleted the bump-k8s-api-0.27 branch July 28, 2023 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation failure when bumping kube dependencies
5 participants