test: disable deployment configs in openshift 4.14 #1470
Conversation
OpenShift 4.14+ deprecates support for deploymentconfig resources, so we shouldn't run tests that depend on them in those environments. Signed-off-by: Andy Sadler <[email protected]>
|
/lgtm |
sadlerap
added
the
release/v1.3.x
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold This may or may not be necessary; want to follow up with @ascerra if this is an acceptable path forward. |
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1470 +/- ##
=======================================
Coverage 58.16% 58.16%
=======================================
Files 35 35
Lines 3014 3014
=======================================
Hits 1753 1753
Misses 1093 1093
Partials 168 168 Continue to review full report in Codecov by Sentry.
|
|
/unhold |
|
/retest |
|
/test 4.13-acceptance |
|
/retest |
|
/test 4.13-acceptance |
openshift-merge-robot
merged commit 899947f
into
redhat-developer:master
…1470) OpenShift 4.14+ deprecates support for deploymentconfig resources, so we shouldn't run tests that depend on them in those environments. Signed-off-by: Andy Sadler <[email protected]>
OpenShift 4.14+ deprecates support for deploymentconfig resources, so we shouldn't run tests that depend on them in those environments. Signed-off-by: Andy Sadler <[email protected]> Co-authored-by: Andy Sadler <[email protected]>
OpenShift 4.14+ deprecates support for deploymentconfig resources, so we shouldn't run tests that depend on them in those environments.
Changes
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.