Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor unwantedRecommendations setting in .vscode/extensions.json. #16

Closed
rubensa opened this issue Aug 7, 2024 · 5 comments · Fixed by #17
Closed

Honor unwantedRecommendations setting in .vscode/extensions.json. #16

rubensa opened this issue Aug 7, 2024 · 5 comments · Fixed by #17
Assignees
Labels
enhancement New feature or request

Comments

@rubensa
Copy link

rubensa commented Aug 7, 2024

Currently, looks like the only way to avoid Language Support for Java(TM) by Red Hat recommending Dependency Analytics is by disabling all recommendations (setting extensions.ignoreRecommendations to true).

I think that, if this extension is using VSCode "standard" settings to enable/disable recommendations (once the java.recommendations.dependency.analytics.show setting has been removed), it should also respect the unwantedRecommendations setting in .vscode/extensions.json.

@rgrunber rgrunber changed the title [proposal] Honor unwantedRecommendations setting in .vscode/extensions.json. Honor unwantedRecommendations setting in .vscode/extensions.json. Aug 7, 2024
@rgrunber
Copy link
Member

rgrunber commented Aug 7, 2024

Seems like something we should implement in https://github.com/redhat-developer/vscode-extension-proposals . This is assuming the library would have access to the current project folder.

@rgrunber rgrunber added the enhancement New feature or request label Aug 7, 2024
@rubensa
Copy link
Author

rubensa commented Aug 7, 2024

@rgrunber Should I open a issue in that repo or this one is just enough? 🤔

@rgrunber
Copy link
Member

rgrunber commented Aug 7, 2024

I was going to transfer this issue directly there, but @robstryker can't, so maybe @fbricon can when he returns.

@fbricon fbricon transferred this issue from redhat-developer/vscode-java Aug 7, 2024
@fbricon
Copy link
Contributor

fbricon commented Aug 7, 2024

I was going to transfer this issue directly there, but @robstryker can't, so maybe @fbricon can when he returns.

done

@rubensa
Copy link
Author

rubensa commented Sep 5, 2024

Any advance on this?

As this issue prevents us from using the Dependency Analytics extension and, currently, we are forced to disable any extension recommendation via extensions.ignoreRecommendations setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
3 participants