Extension IDs listed for 'unwantedRecommendations' should be ignored. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
commented
Sep 11, 2024
rgrunber
force-pushed
the
unwantedRecommendations
branch
from
721a1e6
to
c5946a5
Compare
rgrunber
changed the title
rgrunber
force-pushed
the
unwantedRecommendations
branch
from
c5946a5
to
00705e1
Compare
|
@robstryker I think it should be good, but let me know if you see anything odd. I'll probably have this merged, and take on the long journey of updating all consumers (but probably vscode-java first as the request originates from there). |
rgrunber
force-pushed
the
unwantedRecommendations
branch
2 times, most recently
from
b9fc85d
to
6b9abe7
Compare
|
This looks like it will read the workspace file |
- Support 'unwantedRecommendations' in .vscode/extensions.json and in the '.code-workspace' (multi-root) files Signed-off-by: Roland Grunberg <[email protected]>
rgrunber
force-pushed
the
unwantedRecommendations
branch
from
6b9abe7
to
b4dbbcc
Compare
|
Added an optional argument for the json data that's read from the configuration file so it can be re-used. |
robstryker
approved these changes
Sep 16, 2024
| .map((x) => x.extensionId) | ||
| .filter(filterUnique) | ||
| .filter((x) => !isExtensionInstalled(x)); | ||
|
|
||
| const jsonData = await readExtensionConfigurationFile(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unwantedRecommendationssetting in .vscode/extensions.json. #16