Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linked correction proposals #3686

Closed
hopehadfield opened this issue Jun 26, 2024 · 4 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#3229 or #3730
Closed

Support linked correction proposals #3686

hopehadfield opened this issue Jun 26, 2024 · 4 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#3229 or #3730

Comments

@hopehadfield
Copy link
Contributor

Add support for linked correction proposals, as is done in Eclipse

linked-proposal

Currently, the same quickfix in vscode-java only gives the first option from the list.

no-linked-proposal

@rgrunber
Copy link
Member

The LSP Spec now supports SnippetTextEdit, so this is possible for code actions. You may have some difficulty sending it on the language server side with the existing lsp4j library as it lacks the necessary classes, but should be possible to work around that. The language client we use (vscode-languageserver-node) also seems to now support it.

@fbricon
Copy link
Collaborator

fbricon commented Jun 27, 2024

As usual, make sure the client supports it before sending SnippetTextEdits

@rgrunber rgrunber moved this to 🏗 In progress in IDE Cloudaptors Jul 17, 2024
@rgrunber
Copy link
Member

An update from @hopehadfield :

dropdown

@rgrunber
Copy link
Member

rgrunber commented Aug 9, 2024

We may have to live with the side effects of microsoft/vscode#63129 since the server-side snippets get an additional indentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment